D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Aug 14 15:13:07 BST 2018


broulik added inline comments.

INLINE COMMENTS

> networkmodel.cpp:220
> +    auto deviceStatistics = device->deviceStatistics();
> +    deviceStatistics->setRefreshRateMs(2000);
> +    connect(deviceStatistics.data(), &NetworkManager::DeviceStatistics::rxBytesChanged, this, [this, device](qulonglong rxBytes) {

Would it be better to only request the data when the statistics are open to avoid wakeups and processing?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14835

To: volkov, #plasma, jgrulich
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180814/a3690dc6/attachment.html>


More information about the Plasma-devel mailing list