D14562: Introduce Theme.smallestFont

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  good idea, 2 comments:
  
  - the import version of platformtheme cannot change or will break existing code
  - needs a smallestfont declared also in all version of qml-base theme implementations, one in controls, one is in the kirigami repo, under controls, one is in the plasma-framework repo, under src/declarativeimports/kirigamiplasmastyle/

INLINE COMMENTS

> kirigamiplugin.cpp:173
>  
> +    //2.6
> +    qmlRegisterUncreatableType<Kirigami::PlatformTheme>(uri, 2, 6, "Theme", "Cannot create objects of type Theme, use it as an attached poperty");

this will break completely every import < 2.6

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D14562

To: volkov, #kirigami, mart
Cc: mart, plasma-devel, apol, davidedmundson, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180806/58336fcb/attachment.html>