D14546: [Service Runner] Look up relative entryPaths

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Aug 2 09:44:44 BST 2018


broulik created this revision.
broulik added reviewers: Plasma, hein, dfaure.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For KCMs we get a relative `entryPath()` for our `KService` resulting in an invalid URL being created.
  
  CCBUG: 397070

TEST PLAN
  - I can now search for "colors" and drag the colors KCM search result to the desktop and have a fully functioning shortcut
  
  The `KSycocaEntry::entryPath()` docs say
  
  > The path can be absolute or relative.
  >  The corresponding factory should know relative to what.
  
  I'm not really a fan of adjusting all kinds of places where we use `entryPath()`, such as Kicker (as reported in the bug report), is there some better way? or at least a `static` resolve path function somewhere?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14546

AFFECTED FILES
  runners/services/servicerunner.cpp

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180802/48876c73/attachment.html>


More information about the Plasma-devel mailing list