D14243: Fix bad model hygiene in Positioner::move()
David Edmundson
noreply at phabricator.kde.org
Wed Aug 1 11:22:35 BST 2018
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
In terms of the part that's changed, it does seem to do the same as before in a more correct way.
In terms of the bigger picture, I am really struggling to follow what this class is doing. Can you please add some comments on the overall proxy structure.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14243
To: hein, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180801/fb5cc7c0/attachment.html>
More information about the Plasma-devel
mailing list