D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update
David Edmundson
noreply at phabricator.kde.org
Mon Apr 30 12:55:14 UTC 2018
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
flatpak_installation_list_installed_refs_for_update can return null,
clearly we expect this as we catch it above and show an waring. But on
finished in the lambda we call refs->len, which obviously crashes.
onFetchUpdatesFinished doesnt' do anything with an empty list.
BUG: 393614
TEST PLAN
None, just read backtrace and code.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12610
AFFECTED FILES
libdiscover/backends/FlatpakBackend/FlatpakNotifier.cpp
To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180430/c051c776/attachment.html>
More information about the Plasma-devel
mailing list