D12498: Fully remove `Application Name` from Details panel

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Apr 27 19:40:50 UTC 2018


bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> authdetails.ui:26
>       <property name="text">
> -      <string>Action:</string>
> +      <string>Action ID:</string>
>       </property>

Can you also change it for the placeholder label (row 2, col 1) - convention is to set both (actual label and placeholder) to the same value.

And while you are at it, use the same colspan value here as for the other col 1 entries (not you fault, missing since D11950 <https://phabricator.kde.org/D11950>).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180427/c7c5bb20/attachment-0001.html>


More information about the Plasma-devel mailing list