D12517: Wayland: when blocking remember latest config change instead of crashing
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Thu Apr 26 09:51:02 UTC 2018
apol added inline comments.
INLINE COMMENTS
> waylandtestserver.cpp:155
> + m_waiting = configurationInterface;
> + return;
> + }
maybe it's a bit easier to understand if you add an else instead of a return?
> waylandtestserver.cpp:160
> //showOutputs();
> Q_EMIT configChanged();
> }
Won't the using code expect `configChanged` to be emitted after `configReceived`?
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D12517
To: romangg, #plasma
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180426/43070848/attachment.html>
More information about the Plasma-devel
mailing list