D12516: Rework InlineMessages to address a number of issues

Eike Hein noreply at phabricator.kde.org
Wed Apr 25 13:15:05 UTC 2018


hein created this revision.
hein added reviewers: Plasma, broulik, mart.
Restricted Application added a project: Kirigami.
hein requested review of this revision.

REVISION SUMMARY
  - Rework the reveal animation to work multiple times (previously on Qt 5.10 the content would stay hidden on a second visible=true.
  - Fix height self-adjustment outside of layouts.
  - Fix warning from setting implicitWidth - InlineMessage users should manage always manage the width of InlineMessage (with a layout or any other way).
  - More correct padding around content item (background border width + one small spacing), makes InlineMessage a few px less tall overall.
  - Get rid of a binding loop for height (by no longer using Control. contentItem).
  - Overall simplify code a little bit.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12516

AFFECTED FILES
  src/controls/InlineMessage.qml
  src/controls/templates/InlineMessage.qml

To: hein, #plasma, broulik, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180425/6fec6367/attachment.html>


More information about the Plasma-devel mailing list