D12476: kcm_opengl: Fix retrieval of DRI information

Alexey Min noreply at phabricator.kde.org
Tue Apr 24 19:33:47 UTC 2018


alexeymin added a comment.


  I've tested this and it seems to work!
  
  F5821132: kinfocenter DRI info wayland.png <https://phabricator.kde.org/F5821132>
  
  But in wayland I had to add some changes: set `IsDirect = true;` before calling `print_screen_info()` in `get_gl_info_egl_qt()` line ~ 929.
  Otherwise, `get_dri_device()` is never called in this block in `print_screen_info()`:
  
    if (IsDirect) {
        if (get_dri_device())  {
            l2 = newItem(l1, i18n("3D Accelerator"));
            l2->setExpanded(true);
            l3 = newItem(l2, l3, i18n("Vendor"), dri_info.vendor);
            l3 = newItem(l2, l3, i18n("Device"), dri_info.device);
            l3 = newItem(l2, l3, i18n("Subvendor"), dri_info.subvendor);
            l3 = newItem(l2, l3, i18n("Revision"), dri_info.rev);
        } else {
            l2 = newItem(l1, l2, i18n("3D Accelerator"), i18n("unknown"));
        }
    }
  
  For X11, `IsDirect` is initialized in `get_gl_info_glx()` line 767 by:
  
    IsDirect = glXIsDirect(dpy, ctx);
  
  Fow wayland path, it stays false forever, I guess. Though direct rendering **IS** used.
  
  Without this hack I only get this:
  F5821138: kinfocenter DRI info wayland bad.png <https://phabricator.kde.org/F5821138>
  
  `3D Accelerator` section is gone, and `Driver` section lacks kernel module information. :(

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12476

To: roberts, #plasma
Cc: alexeymin, wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180424/d05b2ee5/attachment.html>


More information about the Plasma-devel mailing list