D9037: use desktop file actions instead of global shortcuts

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krunnerglobalshortcuts.cpp:34
>  
> -    migrateEnabledPlugins();
> +    KSharedConfig::Ptr config = KSharedConfig::openConfig("kglobalshortcutsrc");
> +    KConfigGroup runnergroup(config, "krunner");

1. you don't need an exe to do that, this whole thing could have been

File=kglobalshortcutsrc
RemoveGroup=krunner

in the .upd. The syntax allows for quite a lot of manipulation.

2. I did something similar for a powerdevil shortcut migration, it has a huge problem.

kconf_update runs, the config updates, kglobalacceld is still running so later syncs undoing your script.

Sorry :/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9037

To: mart, #plasma, davidedmundson
Cc: broulik, apol, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180424/4123ed43/attachment-0001.html>