D12481: Add dptr to models

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> models.h:47
>  
> -    ~AbstractModel() override;
> +    virtual ~AbstractModel() override;
>      QHash<int, QByteArray> roleNames() const Q_DECL_FINAL;

The `override` is sufficient

> models.h:81
> +private:
> +    void *d;
>  };

Why `void*`?

> models_p.h:26
> +
> +class AbstractModelPrivate
> +{

Do we need an explicit `Q_DECL_HIDDEN` or something?

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180423/097cb273/attachment-0001.html>