D12469: Fix avatar picture aliasing and stretching in kickoff

Kirill Tatunov noreply at phabricator.kde.org
Mon Apr 23 18:33:04 UTC 2018


ktatunov added a comment.


  Thanks for the pointer. Upon further investigation it looks like setting
  
    sourceSize.width: width
    sourceSize.height: height
  
  instead of mipmap works well for more or less square images. However, for images that are significantly wider than they are taller (or vice versa) quality is degrading.
  
  F5819557: kickoff-sourcesize-after-horizontal.png <https://phabricator.kde.org/F5819557>
  
  F5819559: kickoff-sourcesize-after-vertical.png <https://phabricator.kde.org/F5819559>
  
  AFAICT, `Image` in qml loads the image in a mode equivalent to `Image.PreserveAspectCrop` (at least in this case) after which `Image`'s scaling kicks in. So images that are really wide or really tall end up being loaded at a resolution that is way off and then scaled.
  I guess it's not that big of a price to pay so I'll replace `mipmap` with `sourceSize`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12469

To: ktatunov, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180423/d8202b5d/attachment.html>


More information about the Plasma-devel mailing list