D12373: Klipper: Remove first history item on clipboard clear

[David Edmundson]

davidedmundson added a comment.


  We have two settings:
  The first, when the X selection owner gets cleared, replaces the clipboard with the top entry
  This one when the X selection owner gets cleared, deletes the top entry in the UI.
  
  Both default to on, which together makes no sense. We're replacing the clipboard and then immediately deleting that same entry.
  
  At a minimum it's a conflicting option that needs to be handled properly.
  
  Even then I'm not 100% convinced.
  
  If a client copies two pieces of sensitive data and then calls clear you've not solved anything.
  
  But more importantly if another X client clears the selection owner even if it doesn't own the previous data, you're just deleting random things. 
  Something we know happens a lot which is why we have that preventEmpty situation on by default.
  
  -
  
  Personally I think the smarter solution (though I understand it's harder to get it in) would be to have keepassx put some hint in the mimeData  x-kde-clipboard-manager-skip-this: true   and then have klipper completely ignore the entry when it gets copied rather than trying to solve a problem after it's already happened.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12373

To: hoffmannrobert
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180420/0eeefbb0/attachment.html>