D12318: Use consistent color button components for color config UI elements

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Apr 18 17:35:08 UTC 2018


kossebau added inline comments.

INLINE COMMENTS

> ColorPicker.qml:34
> +
> +    QtDialogs.ColorDialog {
> +        id: colorDialog

Open question to developers:
how expensive is it to have an instance of ColorDialog per button, instead of sharing one over all buttons?

That's where the code for both ColorButtons here is yet to be aligned.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180418/f7abecf6/attachment.html>


More information about the Plasma-devel mailing list