D12287: [mediaframe applet] Fix defunct adding of new files/folder per DnD

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Apr 17 16:33:27 UTC 2018


kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  It was broken for 2 reasons:
  
  - usage of since-renamed MediaFrame::has() method
  - calling push() directly on plasmoid.configuration.pathList was no-op due to QTBUG-67773

TEST PLAN
  Dropping files & folders onto an existing mediaframe widget results in the
  files & folders being added now.

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixaddingbydropmediaframe

REVISION DETAIL
  https://phabricator.kde.org/D12287

AFFECTED FILES
  applets/mediaframe/package/contents/ui/main.qml

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180417/b905bd3e/attachment.html>


More information about the Plasma-devel mailing list