D12275: FunnelModel: fix invalid model API usage.
David Faure
noreply at phabricator.kde.org
Tue Apr 17 10:39:04 UTC 2018
dfaure created this revision.
dfaure added a reviewer: hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
dfaure requested review of this revision.
REVISION SUMMARY
The new asserts added in qtbase in commit 00c09e752f (Qt 5.11) are triggered
by this invalid code, which sets up the model before the begin* methods.
So Qt already sees the new rowCount in that method, which is wrong.
TEST PLAN
Opening the K menu
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.12
REVISION DETAIL
https://phabricator.kde.org/D12275
AFFECTED FILES
applets/kicker/plugin/funnelmodel.cpp
To: dfaure, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180417/5e20d629/attachment.html>
More information about the Plasma-devel
mailing list