D12240: Save the dialog view settings when closing the dialog without hitting the cancel button
Anthony Fieroni
noreply at phabricator.kde.org
Tue Apr 17 03:58:33 UTC 2018
anthonyfieroni added inline comments.
INLINE COMMENTS
> kdeplatformfiledialoghelper.cpp:108
> m_buttons->addButton(m_fileWidget->cancelButton(), QDialogButtonBox::RejectRole);
> connect(m_buttons, SIGNAL(rejected()), m_fileWidget, SLOT(slotCancel()));
> connect(m_fileWidget->okButton(), SIGNAL(clicked(bool)), m_fileWidget, SLOT(slotOk()));
Even better to me should be
connect(this, &KDEPlatformFileDialog::rejected, m_fileWidget, &KFileWidget::slotCancel);
PS: You can make a different review to change old syntax (SIGNAL/SLOT) to new function pointers.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D12240
To: ngraham, #frameworks
Cc: anthonyfieroni, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180417/a2e1f2d5/attachment.html>
More information about the Plasma-devel
mailing list