D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> SettingsBase.cpp:82
> +    // calculate base window size to an appropriate size
> +    qreal factor = qBound(1.0, QGuiApplication::primaryScreen()->devicePixelRatio()/96., 3.0);
> +    return QSize(1024*factor, 700*factor);

you don't need to divide by 96 anymore; `devicePixelRatio()` gives you a number generally between 1 and 4, depending on the scale factor used. In fact, you might be able to remove the entire `qBounds` part too, since that won't be forwards-compatible with the next decade's 16k displays...

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180416/58fd8260/attachment.html>