D12252: Enlarge window size: wide enough to show both sidebarsUse (adjusted) calculation in `SizeHint` to determine minimum window width to display both sidebars. Manually apply size with call to `resize()`

Nathaniel Graham noreply at phabricator.kde.org
Mon Apr 16 17:25:47 UTC 2018


ngraham added a comment.


  Tested it out! The patch succeeds at altering the default size, but I'm not sure it accomplishes either of the goals of opening large enough to make the home screen and most KCMs look good, nor your intention of making it wide enough to always show both columns (not sure if we should shoot for that, either: Plasma should still be usable on a 1024x768 screen).
  
  My recommendation would be to forget about opening to a size that shows both columns, and focus on opening to a large enough default size that the home screen and most KCMs look good. In my testing, `QSize(1020*factor, 700*factor)` opens to a much more comfortable size for me that results in nearly all KCMs presented without any scrollbars. It doesn't seem like a coincidence that this is very close to 1024x768; almost as if the KCMs were designed for that size in the first place...
  
  With that change, this patch could be marked as fixing https://bugs.kde.org/show_bug.cgi?id=389617

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D12252

To: sharvey, ngraham, mart
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180416/48edadc5/attachment.html>


More information about the Plasma-devel mailing list