D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Chris Holland noreply at phabricator.kde.org
Mon Apr 16 12:24:19 UTC 2018


Zren added inline comments.

INLINE COMMENTS

> davidedmundson wrote in wallpaperplugin.cpp:26
> You don't need to do this.
> 
> QPointer has a custom -> operator
> 
> So m_newStuffDialog->setTitle works just fine.
> 
> Same for in newStuffFinished

I copy pasted from `image.cpp` ... which apparently hasn't been touched in 4 years since the import from kde-workspace.

- https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600

Will that function need updating too?

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180416/14750fa6/attachment.html>


More information about the Plasma-devel mailing list