D12134: [mediaframe applet] Fix broken selection of fill mode

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Wed Apr 11 23:47:01 UTC 2018


kossebau created this revision.
kossebau added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  "comboBoxItems" does not reference anything, at least after
  2700c2f7c5d52aff276bea3774b5bd3552d91157 <https://phabricator.kde.org/R114:2700c2f7c5d52aff276bea3774b5bd3552d91157>
  Instead the model of the combobox created by JS due to i18n() calls needs
  to be indirectly referenced.
  
  To not only avoid some race condition during setup, text of the
  fillModeDescription label is now set by a binding, instead of being
  manually set in onCurrentIndexChanged handler of the combobox

TEST PLAN
  Description of fill mode is now correct on initial config page view.
  Selecting another fill mode results in update of the description.
  Selecting another fill mode now also actually works.

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixmediaframescalingconfig

REVISION DETAIL
  https://phabricator.kde.org/D12134

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180411/abb047c8/attachment.html>


More information about the Plasma-devel mailing list