D12088: port the ksplash kcm to the new design

[David Edmundson]

davidedmundson added a comment.


  I like patches with more red than green. It's a very positive sign ++
  
  Minor comments below

INLINE COMMENTS

> main.qml:51
> +            kcm.selectedPlugin = model.pluginName;
> +            view.currentIndex = index;
> +            view.forceActiveFocus();

Doing this *and* the conection on line 64 seems wrong.

> main.qml:60
> +        view.currentIndex = kcm.selectedPluginIndex;
> +        view.positionViewAtIndex(grid.currentIndex, GridView.Visible)
> +    }

redundant given the onCurrentIndexChanged binding above

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12088

To: mart, #plasma, #vdg
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180410/9d725c5e/attachment-0001.html>