D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Nathaniel Graham noreply at phabricator.kde.org
Sun Apr 8 21:56:20 UTC 2018


ngraham added inline comments.

INLINE COMMENTS

> Zren wrote in ConfigurationContainmentAppearance.qml:159
> "Get New Wallpaper" is capitalized. Are we using lowercase so the "Wallpaper Plugins" stands out more?
> 
> lowercase new vs uppercase New
> 
> F5800706: 2018-04-08___11-09-40.png <https://phabricator.kde.org/F5800706> F5800707: 2018-04-08___11-10-01.png <https://phabricator.kde.org/F5800707>

Sorry for the confusion, I was more commenting on the fact that the word "New" would be included. Following the pattern is a good idea, though I would favor lowercasing the word "new" everywhere (would be in another patch though).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180408/068fff87/attachment.html>


More information about the Plasma-devel mailing list