D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ConfigurationContainmentAppearance.qml:71
>          spacing: units.largeSpacing / 2
> -        anchors.right: wallpaperRow.right
> +        // anchors.right: wallpaperRow.right
>          visible: pluginComboBox.count > 1

Don't leave commented-out code; remove it

> ConfigurationContainmentAppearance.qml:76
> +        //     height: parent.height
> +        // }
>          QtControls.Label {

Don't leave commented-out code; remove it

> ConfigurationContainmentAppearance.qml:159
> +            iconName: "get-hot-new-stuff"
> +            text: i18nd("plasma_shell_org.kde.plasma.desktop", "Get Wallpaper Plugins...")
> +            visible: KAuthorized.authorize("ghns")

It might be a bit wordy, but to be consistent with the form used everywhere else, this should say, "Get new Wallpaper Plugins..."

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12041

To: Zren, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180408/b8132dc3/attachment-0001.html>