D11981: [Image Wallpaper] Fix blur
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Apr 6 09:05:42 UTC 2018
broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This broke in the transition to `StackView` as the blur needs a full-size source. Additionally
- put the item into a `Loader` to avoid needless shader compilation and other work
- only load the blur for image fill modes where the image does not cover the full size
- don't render background color when blur is enabled as you cannot see it anyway
TEST PLAN
- Enabled and disabled blur, verified that the Loader loads and unloads
- Switched between fill modes, verified that the Loader loads and unloads
- Verified that blur renders correctly and looks nice
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D11981
AFFECTED FILES
wallpapers/image/imagepackage/contents/ui/main.qml
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180406/55614548/attachment.html>
More information about the Plasma-devel
mailing list