D11957: [potd dataengine] De-pimplify potd providers for more simple code

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: xuetianweng.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  There is no need to use pimpl for non-public-API classes.
  
  While touching the code, also change to use consistently
  modern signal-slot connections.

TEST PLAN
  All plugins still build, load & work as before.

REPOSITORY
  R114 Plasma Addons

BRANCH
  depimplpotdproviderplugins

REVISION DETAIL
  https://phabricator.kde.org/D11957

AFFECTED FILES
  dataengines/potd/apodprovider.cpp
  dataengines/potd/apodprovider.h
  dataengines/potd/bingprovider.cpp
  dataengines/potd/bingprovider.h
  dataengines/potd/epodprovider.cpp
  dataengines/potd/epodprovider.h
  dataengines/potd/flickrprovider.cpp
  dataengines/potd/flickrprovider.h
  dataengines/potd/natgeoprovider.cpp
  dataengines/potd/natgeoprovider.h
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h
  dataengines/potd/wcpotdprovider.cpp
  dataengines/potd/wcpotdprovider.h

To: kossebau, xuetianweng
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180405/08cfd5ac/attachment.html>