D11849: [kdecoration] properly compare opacity values
David Edmundson
noreply at phabricator.kde.org
Mon Apr 2 22:10:36 UTC 2018
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Whilst qFuzzyCompare is indeed needed for comparing a calculation with a value, it's not relevant in all cases, like this.
We want setOpacity(actually zero) to update m_opacity over setOpacity(something near zero) as it hypothetically changes QPainter paths which check for actual zero.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D11849
To: zzag, #breeze, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180402/c611375f/attachment-0001.html>
More information about the Plasma-devel
mailing list