D11801: remove m_desktopContainments

[David Edmundson]

davidedmundson added a comment.


  Now that previous containmentForScreen patch is looking a thousand times better. Good stuff.
  
  +1

INLINE COMMENTS

> shellcorona.cpp:1256
>      if (containment) {
>          containment->setActivity(activity);
>          insertContainment(activity, screenNum, containment);

This shouldn't be needed if we pass it as an arg to containmentForScreen

> shellcorona.cpp:1596
> +    Plasma::Containment *oldContainment = containmentForScreen(screen, m_activityController->currentActivity(), QString());
> +qWarning()<<"OLD CONT"<<oldContainment;
>      //no valid containment in given screen, giving up

fix

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11801

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180401/9cb597b3/attachment.html>