D8006: Add edit button to desktop theme
David Edmundson
noreply at phabricator.kde.org
Wed Sep 27 11:28:04 UTC 2017
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This option is only visible in plasmathemeexplorer is installed. This
makes it easy to edit themes, without cluttering the UI of normal users.
Edit button is made similar to the action buttons in the wallpaper
delegate. (though this is copying an existing bug of of using
plasmacomponents where they shouldn't be)
MouseArea got collapsed into the parent Item in the delegate as it makes
for more readable implicit z-ordering to have the button on top.
TEST PLAN
Clicked on one, explorer for that theme appeared.
Faked not having theme explorer by temporarily putting a typo in the service name. No buttons showed
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8006
AFFECTED FILES
kcms/desktoptheme/CMakeLists.txt
kcms/desktoptheme/kcm.cpp
kcms/desktoptheme/kcm.h
kcms/desktoptheme/package/contents/ui/main.qml
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170927/4c0beb3a/attachment.html>
More information about the Plasma-devel
mailing list