D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> openconnectauth.cpp:162
>  
> +    if (!dataMap[NM_OPENCONNECT_KEY_PIN].isEmpty()){
> +         d->isPinProvided = true;

Coding style. Missing space before "{".

> openconnectauth.cpp:165
> +    }
> +    if (!dataMap[NM_OPENCONNECT_KEY_PRIVKEY].isEmpty()){
> +        QString pk = dataMap[NM_OPENCONNECT_KEY_PRIVKEY];

Coding style. Missing space before "{".

> openconnectauth.cpp:167
> +        QString pk = dataMap[NM_OPENCONNECT_KEY_PRIVKEY];
> +        if (pk.startsWith("pkcs11:")){
> +	    d->isPrivKeyPkcs11 = true;

Coding style. Missing space before "{".

> openconnectauth.cpp:168
> +        if (pk.startsWith("pkcs11:")){
> +	    d->isPrivKeyPkcs11 = true;
> +        }

Coding style. Missing indent.

> openconnectauth.cpp:203
> +        QString rawkey = dataMap[NM_OPENCONNECT_KEY_PRIVKEY];
> +        if (d->isPinProvided && d->isPrivKeyPkcs11){
> +            QString pin = dataMap[NM_OPENCONNECT_KEY_PIN];

Coding style. Missing space before "{".

> openconnectauth.cpp:397
>      }
> +    if ( pair.second >= OpenconnectAuthWidgetPrivate::Debug &&
> +         d->isPinProvided && d->isPrivKeyPkcs11){

Coding style. No space after "if (" and also the whole condition can be on one line, it's not that long.

> openconnectauth.cpp:398
> +    if ( pair.second >= OpenconnectAuthWidgetPrivate::Debug &&
> +         d->isPinProvided && d->isPrivKeyPkcs11){
> +        // mask pin in log

Coding style. Missing space before "{".

> openconnectauth.cpp:400
> +        // mask pin in log
> +        pair.first=pair.first.replace(QRegExp("pin-value=[0-9]+$"),"pin-value=XXXXXXXX");
> +    }

Coding style. Missing space before and after "=".

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D7795

To: thorstenb, #plasma, jgrulich
Cc: jgrulich, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170925/09872603/attachment.html>