D7937: Don't reload background contrast effect on screen resize
Martin Flöser
noreply at phabricator.kde.org
Fri Sep 22 13:33:37 UTC 2017
graesslin added inline comments.
INLINE COMMENTS
> contrast.cpp:79
> + }
> + foreach (EffectWindow *window, effects->stackingOrder())
> + updateContrastRegion(window);
please no foreach in new code, please use range-based for. (Reason: I don't trust Qt to keep it after there was a prominent blog post about deprecating foreach)
> contrast.cpp:79-80
> + }
> + foreach (EffectWindow *window, effects->stackingOrder())
> + updateContrastRegion(window);
> }
Please use {}
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7937
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170922/30d5c3e1/attachment.html>
More information about the Plasma-devel
mailing list