D7885: Don't crash if a client (legally) uses deleted global contrast manager

David Edmundson noreply at phabricator.kde.org
Wed Sep 20 13:18:03 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  There is a race condition in the following situation:
  
  - Server creates a global
  - Client binds to that global (making a new resource for that
  
  global)
  
    Simultaneously:
    - The client uses this resource
    - The server deletes the global
  
  This was fixed for Blur, but as mention in that commit can also happen here.
  Code is effectively a copy and paste from https://phabricator.kde.org/R127:eaac3948f1499b638799f05b6b229ee30b02eb9a

TEST PLAN
  Unit test. Booted normal session

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7885

AFFECTED FILES
  autotests/client/test_wayland_registry.cpp
  src/server/contrast_interface.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170920/6abfa662/attachment.html>


More information about the Plasma-devel mailing list