D7877: Don't recreate kwayland blurmanager on screen size changes

David Edmundson noreply at phabricator.kde.org
Tue Sep 19 13:44:45 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.

REVISION SUMMARY
  Instead of calling reconfigure() on screen size changes, which deletes
  and recreates the effect, we can just update the one texture that's mapped to
  the screen size.
  
  ---
  
  From the wayland commit.
  
  > What surprises me is that BlurManager recreates for Output changes.
  > That sounds like a bug in KWin (or an area which could be improved).
  
  I had thought the same and wrote this (though wanted to have kwayland first)

TEST PLAN
  Logged in and out (my screen resizes on startup due to scaling)
  Tested on my X machine by turning a screen off. Nothing broke, plasma
  panels looked the same.
  
  Note: Eike tried this patch last week and claimed kwin still crashed.
  We don't have a backtrace so it could have been something unrelated,
  applied wrong or that he was deliberately lying to wind me up.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7877

AFFECTED FILES
  effects/blur/blur.cpp
  effects/blur/blur.h

To: davidedmundson, #plasma
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170919/124f3a64/attachment.html>


More information about the Plasma-devel mailing list