D7870: Don't crash if a client (legally) uses a deleted global

David Edmundson noreply at phabricator.kde.org
Mon Sep 18 18:39:57 UTC 2017


davidedmundson marked 2 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in blur_interface.cpp:49
> QPointer itself can determine that resource is deleted but QPointer* acts like every normal pointer e.g. it can be dangling. So if unbind is called before cast this line will crash.

I'm not going to get a callback on a resource if the resource doesn't exist. (Libwayland would have already crashed if that happens)

That's not what we're guarding against here.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7870

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170918/ba5eff62/attachment-0001.html>


More information about the Plasma-devel mailing list