D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE

Martin Flöser noreply at phabricator.kde.org
Sun Sep 17 07:44:19 UTC 2017


graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The implementation of grabXKeyboard checks whether the passed in arg
  is XCB_WINDOW_NONE and sets the arg to rootWindow. Thus we don't need
  to have rootWindow as the default argument, but can have none as the
  default arg.

TEST PLAN
  Compiles, test which uses the default arg still passes

REPOSITORY
  R108 KWin

BRANCH
  grab-x-keyboard-none-window

REVISION DETAIL
  https://phabricator.kde.org/D7857

AFFECTED FILES
  utils.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170917/94af7798/attachment.html>


More information about the Plasma-devel mailing list