D7846: [tabbox] Drop the passing to Effects in X11 Filter

Martin Flöser noreply at phabricator.kde.org
Sat Sep 16 09:34:48 UTC 2017


graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  If an Effect has replaced the TabBox and wants to react on mouse events
  the EffectsHandlerImpl also has an X11Filter, so we only need to make
  sure the events go to that filter.
  
  Motion: TabBox did not filter out, so events will go to the Effects
  filter.
  Press/Release: TabBox should not operate if Effects take the events.
  The events are filtered out by Effects if there is a grab, so just
  check for that and go out. Effects will take care.

TEST PLAN
  Compiles

REPOSITORY
  R108 KWin

BRANCH
  tabbox-no-effects-in-filter

REVISION DETAIL
  https://phabricator.kde.org/D7846

AFFECTED FILES
  effects.cpp
  effects.h
  tabbox/x11_filter.cpp
  tabbox/x11_filter.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170916/5d823709/attachment-0001.html>


More information about the Plasma-devel mailing list