D7814: Disable shortcuts for actions not on the current page

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Thu Sep 14 12:22:12 UTC 2017


leinir created this revision.
leinir added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This ensures we can have actions on multiple pages which use the same shortcut keysequences without running into clashes (which then in turn disables the shortcuts for /any/ action using it, not only subsequent ones). If the action is not in a page (that is, the default state for an action), it will simply always have the keysequence assigned. This means that, should you wish, you can manually handle this behaviour, which is the current situation.

TEST PLAN
  Without this patch, having two pages on the page stack at the same time using the same shortcut keysequence for their actions (for example, two instances of the same page), will result in all those actions failing to work once the second page is instantiated.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D7814

AFFECTED FILES
  src/controls/Action.qml
  src/controls/Page.qml
  src/controls/private/PageActionPropertyGroup.qml

To: leinir, #kirigami, mart
Cc: plasma-devel, #kirigami, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170914/2969d5bd/attachment.html>


More information about the Plasma-devel mailing list