D7796: Use flatpak_installation_list_installed_refs for listing installed flatpaks

Jan Grulich noreply at phabricator.kde.org
Wed Sep 13 13:43:47 UTC 2017


jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> FlatpakBackend.cpp:614
>  
> -            AppStream::Component appstreamComponent(metadata.component());
> -            FlatpakResource *resource = new FlatpakResource(appstreamComponent, flatpakInstallation, this);
> +        const QString fnDesktop = pathApps + name + QLatin1String(".desktop");
>  

This will break for apps which .desktop file name doesn't match flatpak ref name. Also you can filter out runtimes and .Locale resources before you get here to avoid errors.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D7796

To: apol, jgrulich
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170913/2597f402/attachment.html>


More information about the Plasma-devel mailing list