D7765: make krunner accessible

Frederik Gladhorn noreply at phabricator.kde.org
Mon Sep 11 21:00:55 UTC 2017


gladhorn added a comment.


  Lovely! Just a bit of nit-picking.

INLINE COMMENTS

> view.cpp:65
>  
> +    //used only by on screen readers
> +    setTitle(i18n("KRunner"));

I'd remove the "on" :)

> RunCommand.qml:120
>              }
> -            Keys.forwardTo: [listView, results]
> +            //Keys.forwardTo: [listView, results]
>          }

Left over comment?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7765

To: mart, #plasma, davidedmundson, broulik
Cc: gladhorn, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170911/4c62a028/attachment.html>


More information about the Plasma-devel mailing list