D7766: make krunner accessible

Marco Martin noreply at phabricator.kde.org
Mon Sep 11 20:52:31 UTC 2017


mart added inline comments.

INLINE COMMENTS

> broulik wrote in ResultDelegate.qml:50
> So we end up with " , in category foo" if subtextLabel is empty?

pretty much, i can make 2 different strings at all, the oddity if if it's a null string, i18n thinks it's a single patameter and complains about wrong parameters number

> broulik wrote in ResultsView.qml:140
> Can we perhaps bind the "isCurrentItem" to activeFocus instead of doing this in addition to incrementing/decrementing the index?

will give a try

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D7766

To: mart, #plasma, davidedmundson, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170911/f4c89477/attachment.html>


More information about the Plasma-devel mailing list