D7761: [effects] Support xcbConnectionChanged for support properties

Martin Flöser noreply at phabricator.kde.org
Sun Sep 10 20:04:41 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in blur.cpp:76
> I was expecting you to do what you for the present windows effect with calling your local lambda announceSupportProperties.
> 
> IMHO it's neater than duplicating - but this is fine too.

I didn't go for the lambda here as the if statement above does also the Wayland registering. So at least the if would have been needed to be duplicated anyway.

REPOSITORY
  R108 KWin

BRANCH
  effects-xcb-connection-changed

REVISION DETAIL
  https://phabricator.kde.org/D7761

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170910/41b14a58/attachment.html>


More information about the Plasma-devel mailing list