D7716: Support filepaths with accents
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Thu Sep 7 13:33:01 UTC 2017
apol added inline comments.
INLINE COMMENTS
> sddmauthhelper.cpp:228
> +int main(int argc, char **argv) {
> + qputenv("LANG", "C.UTF-8");
> + return KAuth::HelperSupport::helperMain(argc, argv, "org.kde.kcontrol.kcmsddm", new SddmAuthHelper());
I just realized we have something similar in samba-mounter for the exact same reason:
https://cgit.kde.org/samba-mounter.git/tree/src/helper/sambahelper.cpp#n49
In this case we're forwarding the LANG from the user: in the end it's what the user requested not something specific to UTF-8. Nobody is enforcing paths to be utf8 AFAIK.
I wonder if we could come up with a generic solution...
REPOSITORY
R123 SDDM Configuration Panel (KCM)
REVISION DETAIL
https://phabricator.kde.org/D7716
To: davidedmundson, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170907/7ad0b76e/attachment.html>
More information about the Plasma-devel
mailing list