D7686: Don't show a region selector when selecting avatars from a gallery
David Edmundson
noreply at phabricator.kde.org
Mon Sep 4 11:36:58 UTC 2017
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Prompting the user for a region makes sense when loading from a file,
but not from the gallery.
CreateAvatarJob does two things:
- copies from KIO
- goes via a KPixmapRegionSelector and saves to a local file
We know the gallery files are locally mounted, and we don't want the
region selector so we can just skip the job completely.
TEST PLAN
Set avatar from file. Got prompt, saved properly
Set avatar from gallery. Skipped prompt, saved properly
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7686
AFFECTED FILES
src/accountinfo.cpp
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170904/f8226b12/attachment.html>
More information about the Plasma-devel
mailing list