D8582: [platforms/drm] Add support for rotation property on the Plane

[David Edmundson]

davidedmundson added a comment.


  Do you think we'll need a compositor fallback?
  
  *If* we do have a compositor fallback, then I don't see the point of a DRM specific codepath, it's not going to have any slower having a transform in painting, and will just result in one code path not getting tested.
  
  To mostly answer my own question:
  
  In hwcomposer, it seems we have a transform attribute on the layer.
  
  For nested wayland we can set a transform on our wl_surface.
  
  For FBDev or nested in X, I don't think we can. But probably don't care?

INLINE COMMENTS

> drm_object_plane.h:63
> +    enum class Rotation {
> +        Rotate0 = 1 << 0,
> +        Rotate90 = 1 << 1,

why don't we use DRM_MODE_ROTATE_0 for the values?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8582

To: graesslin, #kwin, #plasma, subdiff
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171031/400edb1e/attachment.html>