D8582: [platforms/drm] Add support for rotation property on the Plane

[Roman Gilg]

subdiff added inline comments.

INLINE COMMENTS

> drm_object_plane.cpp:125
> +{
> +    if (m_rotation == r) {
> +        return;

Check not necessary.

> drm_object_plane.h:107
>      uint32_t m_possibleCrtcs;
> +    Rotation m_rotation = Rotation::Rotate0;
>  };

I wouldn't add an additional variable, since its value is saved in the Rotation property. You can retrieve it by calling

  DrmObject::value((int)PropertyIndex::Rotation)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8582

To: graesslin, #kwin, #plasma, subdiff
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171031/7bd05df5/attachment.html>