D8561: [d_ptr] Do not harsh destroy QThread

Anthony Fieroni noreply at phabricator.kde.org
Tue Oct 31 08:35:54 UTC 2017


anthonyfieroni added a comment.


  In https://phabricator.kde.org/D8561#162062, @davidedmundson wrote:
  
  > Wouldn't it be cleaner to put the quit in:
  >
  > Resources::Private::~Private 
  >  and/or ResourceScoreMaintainer::Private::~Private
  >
  > (also I have no idea what the Resource thread is for, literally the only thing it does actually in the thread is sleep)
  
  
  
  
  > Yeah, it's clear to put in where private is QThread, but i think this way is more consistent.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D8561

To: anthonyfieroni, #plasma, davidedmundson, ivan
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171031/9f5bb4ba/attachment.html>


More information about the Plasma-devel mailing list