D8563: Folder View icons properties: Improve visual layout

[Jonathan Marten]

marten created this revision.
marten added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change is similar to https://phabricator.kde.org/D8424, for the "Icons" tab of the dialogue.  In the current layout:
  
  F5459638: folderview-properties-icons_BEFORE.png <https://phabricator.kde.org/F5459638>
  
  the controls are all of varying sizes and are not aligned, and the group titles are indented so far that they are not immediately recognisable as such.
  
  The revised layout:
  
  F5459640: folderview-properties-icons_AFTER.png <https://phabricator.kde.org/F5459640>
  
  uses a single grid layout to enforce the sizes and alignment of the GUI controls.
  
  Note that the screen shots above have had the QML tweaked to show all of the controls, in order to demonstrate the entire layout.  In practice (and in the diff here of course) not all of the controls are shown depending on the containment type of the folder view.

TEST PLAN
  Built plasma-desktop with this change. Checked appearance and operation of the configuration dialogue both as a desktop containment and as a standalone plasmoid.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8563

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigIcons.qml

To: marten, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171031/8f5c5ce1/attachment.html>