D5931: ColorCorrect Library - for configuring KWin's native color correction (in particular Night Color)

David Edmundson noreply at phabricator.kde.org
Mon Oct 30 11:45:02 UTC 2017


davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> geolocator.cpp:25
> +{
> +    m_engine = dataEngine("geolocation");
> +

meh, I'd rather we didn't have to link the rather heavy Plasma from KDED.

I'm not going to make you change it, but in future hopefully we can just use the geo code directly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5931

To: subdiff, #plasma, davidedmundson
Cc: davidedmundson, HuShifang, leezu, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171030/3b344063/attachment.html>


More information about the Plasma-devel mailing list