D8526: add a background in ScrollView

[David Edmundson]

davidedmundson added a comment.


  In general ++. The frame is useful for keyboard focus indication if nothing else.

INLINE COMMENTS

> ScrollView.qml:47
> +        visible: false
> +        elementType: "edit"
> +

As in a textedit?

The QQC1 code used "frame" which is semantically more appropriate.

Did you do this to get the white background?

In QWidgets a scrollarea is transparent, and an itemview is white.

I think we might need some way (extra Kirigami class ?) to have both.

I suggest holding out on merging till we do a bit more KCM porting and figure that out.

> ScrollView.qml:79
>                  }
> -                //TODO: use kirigami for this more granular control
> +                //TODO: use kirigami for this more granular controlRoot
>                /*  var sampleItem = flickableItem.itemAt ? flickableItem.itemAt(0,flickableItem.contentY) : null;

:D

maybe don't find and replace this

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8526

To: mart, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171027/fd500ae8/attachment.html>