D8460: Refactor kcm_input to enable having multiple backends.

[Roman Gilg]

subdiff added a comment.


  A kapplymousetheme binary is for sure only needed in the context of X. I would therefore not write it by the tools of the backend plugin system, but leave it as it is and put it in the X11 backend directory (and put its cmake code into the X11 cmake file). That will reduce the necessary linking for the binary.

INLINE COMMENTS

> mouse.cpp:82
>  MouseConfig::MouseConfig(QWidget *parent, const QVariantList &args)
> -  : KCModule(parent, args)
> +  : KCModule(parent, args), backend(MouseBackend::implementation())
>  {

Break into two lines.

> mousebackend.cpp:32
> +    //There are multiple possible backends
> +    if (KWindowSystem::isPlatformX11()) {
> +        static QThreadStorage<QSharedPointer<X11MouseBackend>> backend;

Until there is a full backend plugin for Wayland the X backend needs to be used on Wayland as well for Xwayland stuff (see the `extern "C"` method).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8460

To: xuetianweng, subdiff, davidedmundson, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171026/3e8c6c0d/attachment.html>